From be1904b3d05868371657653d80dcae80432a9588 Mon Sep 17 00:00:00 2001 From: abdallamohamedcore <57271690+abdallamohamedcore@users.noreply.github.com> Date: Thu, 16 Apr 2020 22:49:31 +0200 Subject: [PATCH 1/4] [13.0] employee_check_list: solve internal user access fields --- .../models/employee_master_inherit.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/employee_check_list/models/employee_master_inherit.py b/employee_check_list/models/employee_master_inherit.py index de085b1e6..86c3f3f23 100644 --- a/employee_check_list/models/employee_master_inherit.py +++ b/employee_check_list/models/employee_master_inherit.py @@ -44,14 +44,16 @@ class EmployeeMasterInherit(models.Model): entry_checklist = fields.Many2many('employee.checklist', 'entry_obj', 'check_hr_rel', 'hr_check_rel', string='Entry Process', - domain=[('document_type', '=', 'entry')]) + domain=[('document_type', '=', 'entry')], + groups='hr.group_hr_user') exit_checklist = fields.Many2many('employee.checklist', 'exit_obj', 'exit_hr_rel', 'hr_exit_rel', string='Exit Process', - domain=[('document_type', '=', 'exit')]) - entry_progress = fields.Float(compute=entry_progress, string='Entry Progress', store=True, default=0.0) - exit_progress = fields.Float(compute=exit_progress, string='Exit Progress', store=True, default=0.0) - maximum_rate = fields.Integer(default=100) - check_list_enable = fields.Boolean(invisible=True, copy=False) + domain=[('document_type', '=', 'exit')], + groups='hr.group_hr_user') + entry_progress = fields.Float(compute=entry_progress, string='Entry Progress', store=True, default=0.0, groups='hr.group_hr_user') + exit_progress = fields.Float(compute=exit_progress, string='Exit Progress', store=True, default=0.0, groups='hr.group_hr_user') + maximum_rate = fields.Integer(default=100, groups='hr.group_hr_user') + check_list_enable = fields.Boolean(invisible=True, copy=False, groups='hr.group_hr_user') class EmployeeDocumentInherit(models.Model): From 2be5f2f04938caba48108b2317e7c91f566aa8b8 Mon Sep 17 00:00:00 2001 From: abdallamohamedcore <57271690+abdallamohamedcore@users.noreply.github.com> Date: Thu, 16 Apr 2020 22:55:23 +0200 Subject: [PATCH 2/4] [FIX] employee_documents_expiry: allow to store without expire date --- employee_documents_expiry/models/employee_documents.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/employee_documents_expiry/models/employee_documents.py b/employee_documents_expiry/models/employee_documents.py index 93b87b672..f71e9be28 100644 --- a/employee_documents_expiry/models/employee_documents.py +++ b/employee_documents_expiry/models/employee_documents.py @@ -51,7 +51,7 @@ class HrEmployeeDocument(models.Model): def check_expr_date(self): for each in self: exp_date = each.expiry_date - if exp_date < date.today(): + if exp_date and exp_date < date.today(): raise Warning('Your Document Is Already Expired.') name = fields.Char(string='Document Number', required=True, copy=False) From fd1b6c5b8b4e0c98c43bc8350cea183c0f9164f9 Mon Sep 17 00:00:00 2001 From: abdallamohamedcore <57271690+abdallamohamedcore@users.noreply.github.com> Date: Thu, 16 Apr 2020 23:23:23 +0200 Subject: [PATCH 3/4] [FIX] employee_documents_expiry: wrong default id --- employee_documents_expiry/models/employee_documents.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/employee_documents_expiry/models/employee_documents.py b/employee_documents_expiry/models/employee_documents.py index f71e9be28..0ceeff29b 100644 --- a/employee_documents_expiry/models/employee_documents.py +++ b/employee_documents_expiry/models/employee_documents.py @@ -90,7 +90,7 @@ class HrEmployee(models.Model): Click to Create for New Documents

'''), 'limit': 80, - 'context': "{'default_employee_ref': '%s'}" % self.id + 'context': {'default_employee_ref': self.id} } document_count = fields.Integer(compute='_document_count', string='# Documents') From 88dd75e882acef4b8c06e76aed036a5201664824 Mon Sep 17 00:00:00 2001 From: abdallamohamedcore <57271690+abdallamohamedcore@users.noreply.github.com> Date: Thu, 16 Apr 2020 23:24:00 +0200 Subject: [PATCH 4/4] [FIX] employee_documents_expiry: solve internal user access fields --- employee_documents_expiry/models/employee_documents.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/employee_documents_expiry/models/employee_documents.py b/employee_documents_expiry/models/employee_documents.py index 0ceeff29b..4fb243500 100644 --- a/employee_documents_expiry/models/employee_documents.py +++ b/employee_documents_expiry/models/employee_documents.py @@ -93,7 +93,7 @@ class HrEmployee(models.Model): 'context': {'default_employee_ref': self.id} } - document_count = fields.Integer(compute='_document_count', string='# Documents') + document_count = fields.Integer(compute='_document_count', string='# Documents', groups='hr.group_hr_user') class HrEmployeeAttachment(models.Model):